forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] androidx-main from androidx:androidx-main #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes session-based API for rear display mode to better reflect that the entire device is moving to the rear facing display, as well as how it is sticky even if the app that requests the move is backgrounded or killed. This CL also updates the presentContentOnWindowArea method to take a WindowAreaToken object instead of a Binder token Moves the `WindowAreaInfo#getActiveSession` API to be more correctly on the `WindowAreaController`. This is a breaking CL in the attempt to stabilize and remove the experimental tag on the Window Area API's. Relnote: "Renamed transferActivityToWindowArea to transferToWindowArea to be clearer about the behavior when triggering the feature. This also removes the session based behavior for this method as it's an operation that outlives the process that requests it." Bug: 271644150 Fixes: 273807246 Fixes: 272064992 Fixes: 473870239 Test: WindowAreaControllerImplTest Change-Id: Ie7d6fa7258d323363748e25fade8d658c1f0f510
Update the implementation and androidTestImplementation dependencies following the latest androidx.core and androidx.activity releases. Bug: 462178249 Test: existing test suites pass Relnote: N/A Change-Id: I2efdbb0c3fb92c96df6e7f2ec063d39d9a363853
Updates RuntimeUtilsTest.java to align with the stricter null-safety contract
introduced in com.android.extensions.xr.node.InputEvent.HitInfo.
The HitInfo class now strictly enforces NonNull for its parameters,
meaning test cases attempting to pass null to these parameters are no longer valid and will throw.
Specifically:
- Removed getHitInfo_nullInputNode_returnsNull: Not applicable as inputNode in HitInfo is always NonNull.
- Removed getHitInfo_nullTransform_returnsNull: Not applicable as transform in HitInfo is always NonNull.
- Removed getHitInfo_nullHitEntity_returnsNull: getHitInfo_unKnownNode_returnsNull already cover this case
if I take an unknow node into HitInfo of XrExtensions.
Bug: 475709106
Test: Presubmit
Change-Id: Icffbda4ceb544dd6964ad538c3537a7ce7e28830
Relnote: "Add a boolean flag to PaneScaffoldDirective to opt out the behavior that automactically moves the focus to the current destination pane." Test: manual Bug: 445720462 Change-Id: I929f5960c59f10a82b53d701eaf757da9e20f9e2
Change-Id: I5d6ab48d7db2320710401393648096ca31351376
This refactoring moves the gapbuffer specific change list implementation to the gapbuffer package. This is a step in a larger refactoring that will eventually allow a new composer implementation, based on a link buffer instead of a gap buffer, to land behind a flag. Test: N/A - refactor Relnote: N/A Bug: 268366116 Change-Id: Icab1f6421c1bf1d9b2615492912e76c1f03e5bb6
Bug: 474095550 Test: Presubmit Relnote: n/a Change-Id: I9fba6e9e2b1d748b68e2617c192dad2a3d13d225
…in sync with the version being provisioned by Benchmark. * The app expected `1.0.0`, but benchmark provided `1.0.1`. * This situation should get better once we switch to using Tracing 2.0.0. Test: TrivialPerfettoSdkBenchmark now passes. Fixes: 464447859 Change-Id: Id8543b170b5c41e118f26f5fa903502be48dcaa1
* This is not safe to do given we might end up dropping a trace packet when ending a trace section. * We fallback to allocations here to gracefully recover. Test: Ignored the dropped event tests. All other unit tests pass. Change-Id: Iefa0cebf7d2ad34d02ba53881da48b4d80e5d9fa
Change-Id: I299590bde7e22c144abb79eb2f6377488df3cf53
…racing in sync with the version being provisioned by Benchmark." into androidx-main
…migration This commit updates XrExtensions' object comparison logic following the package name migration. Due to `com.android.extensions.xr.*` objects now acting as wrappers for `android.extensions.xr.*` objects, `isSameInstanceAs` is no longer reliable. Two distinct wrapper instances can represent the same underlying object. Comparison must now use `isEqualTo` (which calls the wrapped object's `equals()` method) to correctly determine if two wrapper objects refer to the same underlying entity. Bug: 475752776 Test: Presubmit Change-Id: Ia258fb005d494941227beadaa100d65d4b3ab1a5
…ackage migration" into androidx-main
…nsionsWrapperImplTest. Fixed an issue where mBuilder was not initialized, causing it to be null. This was discovered after a test case threw a null exception following an update to the XrExtensions fake runtime. Bug: 475746834 Test: Presubmit Change-Id: Ia60f31cea551f6c23ec798ae7895db1f459fb7f5
…ackExtensionsWrapperImplTest." into androidx-main
…ontract" into androidx-main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )